[PATCH] D31742: [Builtins] Fix lit test setup for Windows

[Weiming Zhao via Phabricator via llvm-commits]

weimingz updated this revision to Diff 94466.
weimingz added a comment.

I tried to use the lib name from cmake/Module/AddCompilerRT.cmake : add_compiler_rt_runtime but no luck. 
And I can't find where the suffix is set in compiler-rt project.


https://reviews.llvm.org/D31742

Files:
  test/builtins/Unit/lit.cfg
  test/builtins/Unit/lit.site.cfg.in


Index: test/builtins/Unit/lit.site.cfg.in
===================================================================
--- test/builtins/Unit/lit.site.cfg.in
+++ test/builtins/Unit/lit.site.cfg.in
@@ -4,7 +4,7 @@
 config.builtins_lit_source_dir = "@BUILTINS_LIT_SOURCE_DIR@/Unit"
 config.target_cflags = "@BUILTINS_TEST_TARGET_CFLAGS@"
 config.target_arch = "@BUILTINS_TEST_TARGET_ARCH@"
-
+config.builtins_is_msvc = "@MSVC@"
 # Load common config for all compiler-rt lit tests.
 lit_config.load_config(config, "@COMPILER_RT_BINARY_DIR@/test/lit.common.configured")
 
Index: test/builtins/Unit/lit.cfg
===================================================================
--- test/builtins/Unit/lit.cfg
+++ test/builtins/Unit/lit.cfg
@@ -24,7 +24,12 @@
 config.test_source_root = os.path.dirname(__file__)
 
 # Path to the static library
-base_lib = os.path.join(config.compiler_rt_libdir, "libclang_rt.builtins-%s.a "
+is_msvc = get_required_attr(config, "builtins_is_msvc")
+if is_msvc:
+  base_lib = os.path.join(config.compiler_rt_libdir, "clang_rt.builtins-%s.lib"
+    % config.target_arch)
+else:
+  base_lib = os.path.join(config.compiler_rt_libdir, "libclang_rt.builtins-%s.a"
     % config.target_arch)
 
 builtins_source_dir = os.path.join(


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D31742.94466.patch
Type: text/x-patch
Size: 1241 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170407/684b2dc5/attachment.bin>