[PATCH] D31350: AMDGPU : Fix common dominator of two incoming blocks terminates with uniform branch issue.

Wei Ding via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 6 13:22:10 PDT 2017


wdng added inline comments.


================
Comment at: lib/Target/AMDGPU/SIFixSGPRCopies.cpp:331
+static bool hasTerminator(MachineBasicBlock *MBB, const TargetRegisterInfo *TRI) {
+  for (MachineBasicBlock *Pred : MBB->predecessors()) {
+    if (hasTerminatorThatModifiesExec(*Pred, *TRI))
----------------
rampitec wrote:
> You need recursive search to do it.
http://llvm.org/docs/ProgrammersManual.html#iterating-over-predecessors-successors-of-blocks, looks like this has iterated over of all predecessors of a BB, right?


Repository:
  rL LLVM

https://reviews.llvm.org/D31350





More information about the llvm-commits mailing list