[PATCH] D31350: AMDGPU : Fix common dominator of two incoming blocks terminates with uniform branch issue.

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added inline comments.


================
Comment at: lib/Target/AMDGPU/SIFixSGPRCopies.cpp:331
+static bool hasTerminator(MachineBasicBlock *MBB, const TargetRegisterInfo *TRI) {
+  for (MachineBasicBlock *Pred : MBB->predecessors()) {
+    if (hasTerminatorThatModifiesExec(*Pred, *TRI))
----------------
You need recursive search to do it.


================
Comment at: lib/Target/AMDGPU/SIFixSGPRCopies.cpp:334
+      return true;
+    }
+
----------------
Weird brace indention.


Repository:
  rL LLVM

https://reviews.llvm.org/D31350