[PATCH] D31715: [SelectionDAG] TargetLowering::SimplifyDemandedBits how to properly calculate KnownZero bits for ISD::SETCC and ISD::AssertZExt

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/TargetLowering.cpp:794
     }
+    if (getBooleanContents(Op.getOperand(0).getValueType()) ==
+            TargetLowering::ZeroOrOneBooleanContent &&
----------------
RKSimon wrote:
> RKSimon wrote:
> > Use Op0 directly?
> Come to think of it - why are you testing the input op type and not the result type (Op.getValueType()) like above?
I sort of wondered that too, but I just copied the code out of computeKnownBits


https://reviews.llvm.org/D31715