[PATCH] D31715: [SelectionDAG] TargetLowering::SimplifyDemandedBits how to properly calculate KnownZero bits for ISD::SETCC and ISD::AssertZExt

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 6 05:21:20 PDT 2017


RKSimon added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/TargetLowering.cpp:794
     }
+    if (getBooleanContents(Op.getOperand(0).getValueType()) ==
+            TargetLowering::ZeroOrOneBooleanContent &&
----------------
RKSimon wrote:
> Use Op0 directly?
Come to think of it - why are you testing the input op type and not the result type (Op.getValueType()) like above?


https://reviews.llvm.org/D31715





More information about the llvm-commits mailing list