[PATCH] D31443: [LTO] Do not reorder global variables unnecessarily during merging

[Tobias Edler von Koch via llvm-commits]

On 04/04/2017 04:48 PM, Rafael Espíndola wrote:
> My view is that we are changing include/llvm/IR/Module.h instead of
> having them fix their code. No one should ever depend on an IR
> property not specified in the langref and this feels like a slippery
> slope.

Well, it's a utility function that you created by factoring out the code 
we originally discussed here; it currently only has two uses, both in 
LTO. BTW I don't disagree with the refactoring at all, just wanted to 
point out it's not some widely used common code I'm touching.

I'd also like to point out that my main concern at this point is not 
resisting to tell our customers to change their code (they will do that 
in due course), but the unpredictable performance variations between LTO 
and non-LTO this introduces - even at -O0.

Tobias

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.