[PATCH] D31443: [LTO] Do not reorder global variables unnecessarily during merging

Rafael Espíndola via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 4 14:48:18 PDT 2017


On 4 April 2017 at 17:40, Mehdi Amini <mehdi.amini at apple.com> wrote:
> I’m midly in favor of merging this (i.e. unless someone has a strong objection): the patch is harmless, and if it can help one of the LTO consumers (Qualcomm), why not?
> My view is that I’d rather have Qualcomm more involved upstream, and I’m inclined to see this as trying to be welcoming.

My view is that we are changing include/llvm/IR/Module.h instead of
having them fix their code. No one should ever depend on an IR
property not specified in the langref and this feels like a slippery
slope.

Cheers,
Rafael


More information about the llvm-commits mailing list