[PATCH] D31607: [ARM] Use table-gen'd assembly operand diags in ARM asm parser

[Renato Golin via Phabricator via llvm-commits]

rengolin added inline comments.


================
Comment at: lib/Target/ARM/AsmParser/ARMAsmParser.cpp:10089
+ARMAsmParser::getCustomOperandDiag(ARMMatchResultTy MatchError) {
+  switch (MatchError) {
+
----------------
olista01 wrote:
> rengolin wrote:
> > Quick question: why is the switch still here if the only case is the default?
> This will be used once we have operands that need diags that differ depending on subtarget features. Most of these on ARM are register classes, which we can't currently emit diagnostics for, but I have a prototype that allows that.
Right. Maybe we should just remove this for now, and add it back when you add the new code.


Repository:
  rL LLVM

https://reviews.llvm.org/D31607