[PATCH] D31607: [ARM] Use table-gen'd assembly operand diags in ARM asm parser

Oliver Stannard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 4 09:23:16 PDT 2017


olista01 added inline comments.


================
Comment at: lib/Target/ARM/AsmParser/ARMAsmParser.cpp:10089
+ARMAsmParser::getCustomOperandDiag(ARMMatchResultTy MatchError) {
+  switch (MatchError) {
+
----------------
rengolin wrote:
> Quick question: why is the switch still here if the only case is the default?
This will be used once we have operands that need diags that differ depending on subtarget features. Most of these on ARM are register classes, which we can't currently emit diagnostics for, but I have a prototype that allows that.


Repository:
  rL LLVM

https://reviews.llvm.org/D31607





More information about the llvm-commits mailing list