[PATCH] D31481: Change the error message format for undefined symbols.

[Rui Ueyama via llvm-commits]

That's right. I just wrote this patch, but have a bad short memory, ha!

On Thu, Mar 30, 2017 at 12:20 PM, Rafael Espíndola <
rafael.espindola at gmail.com> wrote:

> On 30 March 2017 at 15:18, Rui Ueyama via Phabricator
> <reviews at reviews.llvm.org> wrote:
> > ruiu added inline comments.
> >
> >
> > ================
> > Comment at: lld/ELF/Relocations.cpp:623
> > +  std::string Obj = S.getObjMsg<ELFT>(Offset);
> > +  if (Src.empty() && !Obj.empty())
> > +    Msg += "\n>>> referenced by " + Obj;
> > ----------------
> > rafael wrote:
> >> Obj is never empty, is it?
> > If it is a synthetic section, it can be null, I think.
>
> It returns  "(internal)" for those.
>
> Cheers,
> Rafael
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170330/3cbe9375/attachment.html>