[PATCH] D31481: Change the error message format for undefined symbols.

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 30 12:20:15 PDT 2017


On 30 March 2017 at 15:18, Rui Ueyama via Phabricator
<reviews at reviews.llvm.org> wrote:
> ruiu added inline comments.
>
>
> ================
> Comment at: lld/ELF/Relocations.cpp:623
> +  std::string Obj = S.getObjMsg<ELFT>(Offset);
> +  if (Src.empty() && !Obj.empty())
> +    Msg += "\n>>> referenced by " + Obj;
> ----------------
> rafael wrote:
>> Obj is never empty, is it?
> If it is a synthetic section, it can be null, I think.

It returns  "(internal)" for those.

Cheers,
Rafael


More information about the llvm-commits mailing list