[PATCH] D29866: [PDSE] Add PDSE.

[Daniel Berlin via llvm-commits]

On Wed, Mar 29, 2017 at 9:38 PM, Mehdi AMINI via Phabricator <
reviews at reviews.llvm.org> wrote:

> mehdi_amini added inline comments.
>
>
> ================
> Comment at: lib/Transforms/IPO/PassManagerBuilder.cpp:78
> +static cl::opt<bool> RunPDSE("enable-pdse", cl::init(false), cl::Hidden,
> +                             cl::desc("Run with PDSE instead of DSE."));
> +
> ----------------
> Is "PDSE" supposed to be a well known acronym?

Yes
But we could just expand it if not./


> I feel that the description could be more friendly with `--help` readers.
>
>
Sure.


> It also sounds strange to me that "Partial DSE" is "stronger" than "DSE"
> alone.
>

Partial redundancy elimination is also stronger than redundancy elimination
:)

Partial dead store elimination is "not easy", so a lot of compilers punt.

Intel's compiler does it, as did open64.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170329/da05104c/attachment.html>