[PATCH] D31161: [AMDGPU] New Waitcnt Insertion Pass
Stanislav Mekhanoshin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 29 14:48:48 PDT 2017
rampitec added a comment.
In https://reviews.llvm.org/D31161#713546, @kzhuravl wrote:
> In https://reviews.llvm.org/D31161#709509, @rampitec wrote:
>
> > Test with barrier surrounded with fences is needed. All relevant combinations of fences needs to be checked and pattern shall check that only needed counters are used, wait is produced, and that is only one wait. Please refer to OpenCL barrier() implementation for the code to check.
>
>
> these tests must go downstream however (separate change). we do not have fence implementation upstreamed yet.
It can be in the internal repo, but we need these tests to be sure we are producing right fences for OpenCL barriers.
https://reviews.llvm.org/D31161
More information about the llvm-commits
mailing list