[PATCH] D31161: [AMDGPU] New Waitcnt Insertion Pass

Konstantin Zhuravlyov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 29 14:46:14 PDT 2017


kzhuravl added a comment.

In https://reviews.llvm.org/D31161#709509, @rampitec wrote:

> Test with barrier surrounded with fences is needed. All relevant combinations of fences needs to be checked and pattern shall check that only needed counters are used, wait is produced, and that is only one wait. Please refer to OpenCL barrier() implementation for the code to check.


these tests must go downstream however (separate change). we do not have fence implementation upstreamed yet.


https://reviews.llvm.org/D31161





More information about the llvm-commits mailing list