[PATCH] D31262: MIParser/MIRPrinter: Compute block successors if not explicitely specified

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet added a comment.

Hi Matthias,

Thanks for doing this, this is a long overdue!

> MIRPrinter: Skip printing of block successor lists in cases where the parser is guaranteed to reconstruct it.

I'd like the printer to always print everything. I don't think there is any value in having magic here.

Therefore, LGTM modulo drop the test case changes and MIRPrinter changes.

Cheers,
-Quentin



================
Comment at: lib/CodeGen/MIRParser/MIParser.cpp:16
+
+#include "../MIRPrinter.h"
 #include "MILexer.h"
----------------
Do we have other relative path in the code base?
It feels awful.


Repository:
  rL LLVM

https://reviews.llvm.org/D31262