[PATCH] D31188: [AntiDepBreaker] Do not use getPristineRegs for marking live registers.

[Tim Shen via Phabricator via llvm-commits]

timshen added inline comments.


================
Comment at: llvm/lib/CodeGen/AggressiveAntiDepBreaker.cpp:166-171
+    assert(MF.getFrameInfo().isCalleeSavedInfoValid());
+    const auto &CSI = MFI.getCalleeSavedInfo();
+    return find_if(CSI.begin(), CSI.end(), [Reg](const CalleeSavedInfo &C) {
+             return C.getReg() == Reg;
+           }) != CSI.end();
+  };
----------------
MatzeB wrote:
> This looks like you are replacing the check for pristine regs with manually written code that does the same. Am I missing something?
This is because of Quentin's comment in the bug:

  I would just resort on live ins information, if at all possible.
  If not possible I would work toward making that possible :).

I did it without fully understanding the big picture. :P

It'd be good to have you or someone explain the big picture. :)


https://reviews.llvm.org/D31188