[lld] r297850 - [ELF] - Linkerscript: make Dot public and remove getDot(). NFC.

[Rui Ueyama via llvm-commits]

I reverted the change since that was made based on a miscommunciation.

So if we have a setter and a getter that don't do anything particularly
useful such as

  T getFoo() { return Foo; }
  void setFoo(T Val) { Foo = Val; }

then it makes sense to remove them, but in this case we have a fairly
complicated `setDot` function, and we always set Dot via that function. So
getDot works as a guard to protect the direct access to that variable.

On Thu, Mar 16, 2017 at 6:46 AM, George Rimar <grimar at accesssoftek.com>
wrote:

> >I didn't mean to make it public, but protected.
>
>
> It was protected before. It is used from ScriptParser, so I think either
> we can have
>
> getDot() like before, or make Dot public. I was sure you meant that when
> suggested to remove getter.
>
>
> George.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170316/2a941930/attachment.html>