[PATCH] D30259: GlobalISel: Translate ConstantAggregateZero vectors
Quentin Colombet via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 10 16:42:08 PST 2017
qcolombet added inline comments.
================
Comment at: lib/CodeGen/GlobalISel/IRTranslator.cpp:1018
+ if (!CAZ->getType()->isVectorTy()) {
+ if (!TPC->isGlobalISelAbortEnabled())
+ return false;
----------------
qcolombet wrote:
> I would just return false.
> The caller should check the fallback/abort status.
>
> I know surrounding code does that, but we should fix that as well. I'll have a try.
That's r297535
https://reviews.llvm.org/D30259
More information about the llvm-commits
mailing list