[PATCH] D30558: Fix value numbers in successor blocks if liveout number has changed
Stanislav Mekhanoshin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 2 17:12:13 PST 2017
rampitec added a comment.
In https://reviews.llvm.org/D30558#691234, @MatzeB wrote:
> I remember that handleMove() tries to reuse the existing VNInfo* for the last liverange. Sounds like on of those cases is wrong, and should be fixed rather than doing a postpass expensively patching around liveranges.
That was my first thought, so I debugged handleMove for this case. I did not find a place like this, but maybe I'm just not familiar enough with this piece of code. What's interesting subranges are updated properly.
> That's why we have unittests/MI/LiveIntervalTest.cpp, please add a test.
Thank you for the pointer, I will look into this.
Repository:
rL LLVM
https://reviews.llvm.org/D30558
More information about the llvm-commits
mailing list