[PATCH] D30558: Fix value numbers in successor blocks if liveout number has changed

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 2 16:37:57 PST 2017


MatzeB added a comment.

I remember that handleMove() tries to reuse the existing VNInfo* for the last liverange. Sounds like on of those cases is wrong, and should be fixed rather than doing a postpass expensively patching around liveranges.

> The review does not have a dedicated test case since that is very
>  difficult to force scheduler to reorder two certain instructions, but
>  when I submit https://reviews.llvm.org/D30557 it will break the test CodeGen/AMDGPU/br_cc.f16.ll
>  without this patch.

That's why we have unittests/MI/LiveIntervalTest.cpp, please add a test.


Repository:
  rL LLVM

https://reviews.llvm.org/D30558





More information about the llvm-commits mailing list