[PATCH] D30400: For Thumb1, lower ADDC/ADDE/SUBC/SUBE via the glueless ARMISD nodes, same as already done for ARM and Thumb2.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 2 12:04:29 PST 2017


efriedma added a comment.

> t2ADC / t2SBC are actual encodings (non-predicable

t2ADC should be predicable?  At least, there isn't any restriction imposed by the architecture.

The rest makes sense; I'll stop pushing.

> I don't really see what the problem is, either with the old patterns or with the new code.

I don't really want to mix multiple orthogonal changes, especially without any test coverage.


https://reviews.llvm.org/D30400





More information about the llvm-commits mailing list