[PATCH] D30494: [ELF] - Do not list sections explicitly for finalizeSynthetic()

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: ELF/Writer.cpp:1023-1028
+template <class ELFT> static void finalizeSynthetic(SyntheticSection *SS) {
+  if (!SS || !SS->OutSec || SS->empty())
+    return;
+  SS->finalizeContents();
+  SS->OutSec->template assignOffsets<ELFT>();
+}
----------------
ruiu wrote:
> grimar wrote:
> > ruiu wrote:
> > > This function probably should go away. You shouldn't call assignOffsets every time you finalize one synthetic section.
> > I think so. That is for another patch, this one did not change original logic here.
> Can you do that in this patch too?
This patch is not about changing how we assign offsets, so I do not think that make sence in context of it.
I'll prepare different separate patch for that then and update this when it be landed.


https://reviews.llvm.org/D30494