[PATCH] D30494: [ELF] - Do not list sections explicitly for finalizeSynthetic()

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/Writer.cpp:1023-1028
+template <class ELFT> static void finalizeSynthetic(SyntheticSection *SS) {
+  if (!SS || !SS->OutSec || SS->empty())
+    return;
+  SS->finalizeContents();
+  SS->OutSec->template assignOffsets<ELFT>();
+}
----------------
grimar wrote:
> ruiu wrote:
> > This function probably should go away. You shouldn't call assignOffsets every time you finalize one synthetic section.
> I think so. That is for another patch, this one did not change original logic here.
Can you do that in this patch too?


https://reviews.llvm.org/D30494