[PATCH] D30471: [DAG] Relax conditions under stores of loaded values can be merged

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:12015
+                  (isa<ConstantFPSDNode>(OtherST->getValue()) ||
+                   isa<LoadSDNode>(OtherST->getValue()))))
               continue;
----------------
Is this a correctness check, or a profitability check?  At first glance, it isn't obvious why we're checking any of this here.


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:12414
+      CombineTo(Token0.getNode(), Token);
+      AddToWorklist(Ld);
+    }
----------------
Why do you need to CombineTo twice?  Please explain in a comment.


https://reviews.llvm.org/D30471