[PATCH] D30471: [DAG] Relax conditions under stores of loaded values can be merged

[Sanjay Patel via Phabricator via llvm-commits]

spatel added reviewers: efriedma, hfinkel, andreadb.
spatel added a comment.

The output certainly looks good - thanks!

I'm still not confident in my understanding of chains and tokenfactors, so adding some more potential reviewers. I just made some minor comments for the test file.



================
Comment at: test/CodeGen/X86/merge_store_duplicated_loads.ll:1-4
+; RUN: llc %s -o - | FileCheck %s
+
+
+target triple = "x86_64-unknown-linux-gnu"
----------------
1. Can you please commit these tests before the code change? That way we have a baseline check for today's codegen, and we'll just see the improvements from your patch.

2. If you put the triple in the RUN line, you can use utils/update_llc_test_checks.py to auto-generate the check lines. Then, when you update the tests with the code change, you just run that script again and won't have to manually write any CHECK lines.

3. Please add a comment with 'PR32086' and/or a link to bugzilla here. That makes it easier to keep track of the motivation and backstory for the tests.


https://reviews.llvm.org/D30471