[PATCH] D30216: GlobalISel: Translate ConstantDataVector

[Ahmed Bougacha via Phabricator via llvm-commits]

ab requested changes to this revision.
ab added a comment.
This revision now requires changes to proceed.

I'm not sure we want to use G_SEQUENCE for this.  It seems to me that we should figure out a representation for vectors in general before diving into constants.



================
Comment at: lib/CodeGen/GlobalISel/IRTranslator.cpp:988
+      Ops.push_back(getOrCreateVReg(Elt));
+      Indices.push_back(i * (CV->getElementByteSize() * 8));
+    }
----------------
This isn't always a valid assumption; we can have things like v16i1.

Make this size in bits instead?


https://reviews.llvm.org/D30216