[PATCH] D30311: [ValueTracking] Don't do an unchecked shift in ComputeNumSignBits

[Sanjoy Das via Phabricator via llvm-commits]

sanjoy added inline comments.


================
Comment at: lib/Analysis/ValueTracking.cpp:2210
+      unsigned ShAmtLimited = ShAmt->getLimitedValue(TyBits);
+      if (ShAmtLimited == TyBits)
+        break;  // Bad shift.
----------------
majnemer wrote:
> Should it be == or >= ?
The `getLimitedValue` would've taken care about the `>` case.  Though -- I can change it to `getZExtValue()` if you want.


https://reviews.llvm.org/D30311