[PATCH] D30311: [ValueTracking] Don't do an unchecked shift in ComputeNumSignBits

David Majnemer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 23 17:43:43 PST 2017


majnemer added inline comments.


================
Comment at: lib/Analysis/ValueTracking.cpp:2210
+      unsigned ShAmtLimited = ShAmt->getLimitedValue(TyBits);
+      if (ShAmtLimited == TyBits)
+        break;  // Bad shift.
----------------
Should it be == or >= ?


https://reviews.llvm.org/D30311





More information about the llvm-commits mailing list