[PATCH] D30257: [mips] Fix atomic compare and swap at O0.

[Sagar Thakur via Phabricator via llvm-commits]

slthakur accepted this revision.
slthakur added a comment.
This revision is now accepted and ready to land.

LGTM with minor nits.



================
Comment at: lib/Target/Mips/MipsExpandPseudo.cpp:1
+//===-- ARMExpandPseudoInsts.cpp - Expand pseudo instructions -------------===//
+//
----------------
Nit: "MipsExpandPseudoInsts.cpp"


================
Comment at: lib/Target/Mips/MipsISelLowering.cpp:1410
                                                          unsigned Size) const {
+  llvm_unreachable("Should not have been called!");
   assert((Size == 4 || Size == 8) && "Unsupported size for EmitAtomicCmpSwap.");
----------------
Should we remove this function completely since there are no calls to this function?


Repository:
  rL LLVM

https://reviews.llvm.org/D30257