[PATCH] D29717: [LoopVectorize] Added address space check when analysing interleaved accesses

[Matthew Simpson via llvm-commits]

That will work. I had forgotten we had that helper function lying around
already.

On Wed, Feb 22, 2017 at 10:21 AM, Karl-Johan Karlsson via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

>
>
> On 2017-02-22 16:07, Matthew Simpson wrote:
>
>>
>> On Wed, Feb 22, 2017 at 9:08 AM, Karl-Johan Karlsson via llvm-commits
>> <llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>> wrote:
>>
>>
>>     Is it a fault that DesA.Scev is not of pointer type?
>>
>>
>> After thinking a bit about this, we may be misusing SCEV::getType()
>> here. I haven't looked at your debug output very closely, but the
>> comment
>> <http://llvm.org/docs/doxygen/html/ScalarEvolutionExpression
>> s_8h_source.html#l00217>for
>> SCEVAddExpr indicates that operand order can make a difference. I
>> suggest that we get the pointer types directly from instructions rather
>> than the SCEVs:
>>
>
> Good!
>
>
>> ```
>> if(getPointerOperand(A)->getType()->getPointerAddressSpace() !=
>>    getPointerOperand(B)->getType()->getPointerAddressSpace())
>>   continue;
>> ```
>>
>
> What go you think about this:
>
>       if (getMemInstAddressSpace(A) != getMemInstAddressSpace(B))
>         continue;
>
>
>
>>
>>
>> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170222/07604d6f/attachment.html>