<div dir="ltr">That will work. I had forgotten we had that helper function lying around already.</div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Feb 22, 2017 at 10:21 AM, Karl-Johan Karlsson via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class=""><br>
<br>
On 2017-02-22 16:07, Matthew Simpson wrote:<br>
</span><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">
<br>
On Wed, Feb 22, 2017 at 9:08 AM, Karl-Johan Karlsson via llvm-commits<br></span><span class="">
<<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a> <mailto:<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llv<wbr>m.org</a>>> wrote:<br>
<br>
<br>
    Is it a fault that DesA.Scev is not of pointer type?<br>
<br>
<br>
After thinking a bit about this, we may be misusing SCEV::getType()<br>
here. I haven't looked at your debug output very closely, but the<br>
comment<br></span>
<<a href="http://llvm.org/docs/doxygen/html/ScalarEvolutionExpressions_8h_source.html#l00217" rel="noreferrer" target="_blank">http://llvm.org/docs/doxygen/<wbr>html/ScalarEvolutionExpression<wbr>s_8h_source.html#l00217</a>>for<span class=""><br>
SCEVAddExpr indicates that operand order can make a difference. I<br>
suggest that we get the pointer types directly from instructions rather<br>
than the SCEVs:<br>
</span></blockquote>
<br>
Good!<span class=""><br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
```<br>
if(getPointerOperand(A)->getTy<wbr>pe()->getPointerAddressSpace() !=<br>
   getPointerOperand(B)-><wbr>getType()-><wbr>getPointerAddressSpace())<br>
  continue;<br>
```<br>
</blockquote>
<br></span>
What go you think about this:<br>
<br>
      if (getMemInstAddressSpace(A) != getMemInstAddressSpace(B))<br>
        continue;<div class="HOEnZb"><div class="h5"><br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
<br>
<br>
</blockquote>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br></div>