[PATCH] D30187: [ELF] - Improve diagnostic messages for move location counter errors.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 22 01:20:42 PST 2017


grimar added inline comments.


================
Comment at: lld/trunk/ELF/LinkerScript.h:109
+
+  std::string Location;
 };
----------------
ruiu wrote:
> This needs a comment.
I wonder if it worth to make Location a member of BaseCommand.
Since we also use it in OutputSectionCommand.
At the same time other commands seems do not need it.


Repository:
  rL LLVM

https://reviews.llvm.org/D30187





More information about the llvm-commits mailing list