[PATCH] D30187: [ELF] - Improve diagnostic messages for move location counter errors.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: lld/trunk/ELF/LinkerScript.h:92-94
+  SymbolAssignment(StringRef Name, Expr E, std::string &&Loc)
+      : BaseCommand(AssignmentKind), Name(Name), Expression(E),
+        Location(std::move(Loc)) {}
----------------
Performance is not important at all here, so just pass a copy of a std::string instead of `std::string &&`.


================
Comment at: lld/trunk/ELF/LinkerScript.h:109
+
+  std::string Location;
 };
----------------
This needs a comment.


Repository:
  rL LLVM

https://reviews.llvm.org/D30187