[compiler-rt] r295364 - [PGO] Suspend SIGKILL for PR_SET_PDEATHSIG in profile-write

Renato Golin via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 20 01:22:44 PST 2017


On 17 February 2017 at 17:57, Rong Xu via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> Is this system very slow in file write?

No, it's using a SATAII SSD disk.


> I think the test tries to dump the
> profile while the child process still write the file.
> I have a sleep(1) b/w the end of main process and profile dump. It seems
> this is no enough.

This doesn't make sense.

If the process has ended it should have flushed the I/O. If the OS has
buffered it, it won't try to access the file until it's completely
written. If you can physically remove the disk (USB), then you need a
sync, not a sleep.


> Is it possible to get a temporal access to this machine?
> If not, I can reduce the profile size or have a longer wait period before
> profile dump.

Neither of these solutions seem remotely helpful, as this could break
in other machines, OSs or just less often.

You need to find the source of the leek and plug it.

cheers,
--renato


More information about the llvm-commits mailing list