[PATCH] D30154: MemorySSA: Add support for renaming uses in the updater.

[Daniel Berlin via llvm-commits]

On Sat, Feb 18, 2017 at 10:22 PM, Davide Italiano via Phabricator <
reviews at reviews.llvm.org> wrote:

> davide added a comment.
>
> The code logic looks fine. Some minor comments inline.
>
>
>
> ================
> Comment at: include/llvm/Transforms/Utils/MemorySSAUpdater.h:89-93
> +
>  private:
>    // Move What before Where in the MemorySSA IR.
>    template <class WhereType>
> +  void moveTo(MemoryUseOrDef *What, BasicBlock *BB, WhereType Where);
> ----------------
> Unrelated formatting, I guess.
>
>
> ================
> Comment at: lib/Transforms/Utils/MemorySSA.cpp:1187-1189
> +      // We already visited this during our renaming, which can happen
> when
> +      // being asked to rename multipleblocks. Figure out the incoming
> val,
> +      // which is the last def
> ----------------
> Full stop at the ned of the comment (here and everywhere else)
>
>
> I feel like i need to get emacs to check for this ...


> ================
> Comment at: unittests/Transforms/Utils/MemorySSA.cpp:193
>    MSSA.verifyMemorySSA();
> +  MSSA.dump();
>  }
> ----------------
> IIRC `dump()` is supposed to be used only in a debugger and `print()`
> should be used instead, but I might be wrong.
>
>
This was just there so i could reply to piotr's email :)
Removed.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170218/7d2d8b8f/attachment.html>