[PATCH] D30154: MemorySSA: Add support for renaming uses in the updater.

[Davide Italiano via Phabricator via llvm-commits]

davide added a comment.

The code logic looks fine. Some minor comments inline.



================
Comment at: include/llvm/Transforms/Utils/MemorySSAUpdater.h:89-93
+
 private:
   // Move What before Where in the MemorySSA IR.
   template <class WhereType>
+  void moveTo(MemoryUseOrDef *What, BasicBlock *BB, WhereType Where);
----------------
Unrelated formatting, I guess.


================
Comment at: lib/Transforms/Utils/MemorySSA.cpp:1187-1189
+      // We already visited this during our renaming, which can happen when
+      // being asked to rename multipleblocks. Figure out the incoming val,
+      // which is the last def
----------------
Full stop at the ned of the comment (here and everywhere else)


================
Comment at: unittests/Transforms/Utils/MemorySSA.cpp:193
   MSSA.verifyMemorySSA();
+  MSSA.dump();
 }
----------------
IIRC `dump()` is supposed to be used only in a debugger and `print()` should be used instead, but I might be wrong.


https://reviews.llvm.org/D30154