[PATCH] D29586: [lsan] Enable LSan for arm Linux

[Yury Gribov via Phabricator via llvm-commits]

ygribov added a comment.

One option is to force libasan and tests to compile to ARM (via `-marm` switch) which is known to work. I think common understanding is that fast unwinder is unfixable in Thumb mode.



================
Comment at: lib/sanitizer_common/sanitizer_linux_libcdep.cc:202
     int minor = internal_simple_strtoll(buf + 8, &end, 10);
-    if (end != buf + 8 && (*end == '\0' || *end == '.')) {
+    if (end != buf + 8 && (*end == '\0' || *end == '.' || *end == '-')) {
       int patch = 0;
----------------
m.ostapenko wrote:
> I don't really like this change . Perhaps we can create some white list of terminator symbols, or just drop the check?
Or just !isalpha(*end)?


Repository:
  rL LLVM

https://reviews.llvm.org/D29586