[PATCH] D29586: [lsan] Enable LSan for arm Linux

[Maxim Ostapenko via Phabricator via llvm-commits]

m.ostapenko added a comment.

In https://reviews.llvm.org/D29586#679101, @kcc wrote:

> In https://reviews.llvm.org/D29586#677564, @m.ostapenko wrote:
>
> > Updating. I've enabled slow unwinder for LSan tests on ARM to make them pass regardless of arm/thumb mode and compiler that was used to build LSan runtime.
>
>
> That's pretty bad. 
>  Yes, the tests will pass, but the tool will be utterly useless in real life.  Slow unwinder is just too slow. 
>  And setting fast_unwind_on_malloc=false in the test config means we are not testing what the users are going to use.


I agree. ARM ABI is pretty bad -- in thumb mode we can't use fast unwinder because of known reasons, but I really don't know how can we reliably run LSAN tests on Arm without enabling slow unwinder. In any case, I cannot push these changes -- you are the code owner after all, but even with slow unwinder we got pretty fine results on our distributiive. Is there any way how we can enable LSAN for Arm?


Repository:
  rL LLVM

https://reviews.llvm.org/D29586