[PATCH] D29670: [DebugInfo] Emit address space with DW_AT_address_class attribute for pointer and reference types

[Konstantin Zhuravlyov via Phabricator via llvm-commits]

kzhuravl added a comment.

In https://reviews.llvm.org/D29670#669789, @aprantl wrote:

> I think this *generally* looks fine, there should also be a binary bitcode upgrade testcase that verifies the code form MetadataLoader.cpp:1080


Done, thanks.



================
Comment at: lib/CodeGen/AsmPrinter/DwarfUnit.cpp:847
+  // DW_AT_address_class for pointer and reference types.
+  if (Asm->TM.targetSupportsMultipleAddressSpaces() &&
+        (Tag == dwarf::DW_TAG_pointer_type ||
----------------
dblaikie wrote:
> Similar feedback to one of the other patches - whether or not this hook (targetSupportsMultipleAddressSpaces) is needed or if the "not default address space" (or not zero adderss space) would suffice.
Hook is not needed since we switched to `Optional`.


https://reviews.llvm.org/D29670