[PATCH] D29670: [DebugInfo] Emit address space with DW_AT_address_class attribute for pointer and reference types

Konstantin Zhuravlyov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 16 00:43:33 PST 2017


kzhuravl updated this revision to Diff 88665.
kzhuravl marked 2 inline comments as done.
kzhuravl added a comment.

Address review feedback:

- Switch address space member in `DIDerivedType` class from `unsigned` to `Optional<unsigned>`
- Remove target hook
- Add bitcode upgrade test


https://reviews.llvm.org/D29670

Files:
  bindings/go/llvm/DIBuilderBindings.cpp
  docs/AMDGPUUsage.rst
  include/llvm/IR/DIBuilder.h
  include/llvm/IR/DebugInfoMetadata.h
  lib/AsmParser/LLParser.cpp
  lib/Bitcode/Reader/MetadataLoader.cpp
  lib/Bitcode/Writer/BitcodeWriter.cpp
  lib/CodeGen/AsmPrinter/DwarfUnit.cpp
  lib/IR/AsmWriter.cpp
  lib/IR/DIBuilder.cpp
  lib/IR/DebugInfoMetadata.cpp
  lib/IR/LLVMContextImpl.h
  test/Assembler/debug-info.ll
  test/Bitcode/pointer-address-space.ll
  test/Bitcode/pointer-address-space.ll.bc
  test/DebugInfo/AMDGPU/pointer-address-space.ll
  unittests/IR/MetadataTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D29670.88665.patch
Type: text/x-patch
Size: 36924 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170216/02ea80e6/attachment.bin>


More information about the llvm-commits mailing list