[PATCH] D29991: Daily report: only display non empty result tables to avoid cluttering the UI.

[Kristof Beyls via Phabricator via llvm-commits]

kristof.beyls added a comment.

I think that there are 2 main reasons why a table could be empty for a particular metric on the daily report page: either the test run just didn't collect the metric, or it did collect the metric, but there were no significant deltas that need to be reported.
I'd say that the ideal behaviour would be to not show an empty table when the test run didn't collect the metric; but to show the empty table when test results were collected, but there were no significant deltas.

I'm assuming that implementing that would be a bit more work though.

FWIW, if you think it's already an improvement, I'd agree with removing the table header of an empty table, but I think I'd still would like to keep the h3 heading to indicate that the daily report analyzed that metric, and there is simply nothing interesting to report. I think that can be done by just moving the line '{%- if field_results -%}' one line down from where you've put it now?


https://reviews.llvm.org/D29991