[PATCH] D29991: Daily report: only display non empty result tables to avoid cluttering the UI.

[Arnaud A. de Grandmaison via Phabricator via llvm-commits]

aadg created this revision.
Herald added a subscriber: mcrosier.

This is a useability fix only. Empty tables are only taking space and
this is distracting from the essential overview the daily report page is
supposed to provide. However, this could be considered controversial as
some could prefer to keep the empty tables, thus this commit review
solliciting other users' feedback to check if there is agreement.


https://reviews.llvm.org/D29991

Files:
  lnt/server/ui/templates/reporting/daily_report.html


Index: lnt/server/ui/templates/reporting/daily_report.html
===================================================================
--- lnt/server/ui/templates/reporting/daily_report.html
+++ lnt/server/ui/templates/reporting/daily_report.html
@@ -232,6 +232,7 @@
 {%- endmacro %}
 
 {% for field,field_results in report.result_table|reverse %}
+{%- if field_results -%}
 <h3>Result Table ({{ field.name }})</h3>
 {{ result_header()+"\n  <tbody>" if not report.for_mail }}
 {%- for test,visible_results in field_results -%}
@@ -267,6 +268,7 @@
 {{ "</tbody></table><p>" if report.for_mail }}
 {%- endfor %}
 {{ "</tbody></table>" if not report.for_mail }}
+{%- endif -%}
 {%- endfor -%}
 
 {% endif %}


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D29991.88543.patch
Type: text/x-patch
Size: 697 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170215/7fc6d417/attachment.bin>