[PATCH] D29308: [PM] Hook the instrumented PGO machinery in the new PM

Chandler Carruth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 10 11:22:21 PST 2017


chandlerc accepted this revision.
chandlerc added a comment.
This revision is now accepted and ready to land.

LGTM with a minor tweak above, feel free to just submit with that change unless you'd like to do something different.



================
Comment at: include/llvm/Passes/PassBuilder.h:135-136
+  explicit PassBuilder(TargetMachine *TM = nullptr,
+                       PGOOptions *PGOOpt = nullptr)
+      : TM(TM), PGOOpt(PGOOpt) {}
 
----------------
Pass and store an optional rather than a pointer? Removes lifetime concerns and ownersihp questions, and this seems a not-scary data type to copy.


https://reviews.llvm.org/D29308





More information about the llvm-commits mailing list