[PATCH] D29309: [PM] Add support for instrumented PGO in the new pass manager (clang-side)

[Chandler Carruth via Phabricator via llvm-commits]

chandlerc added inline comments.


================
Comment at: lib/CodeGen/BackendUtil.cpp:805
+    else
+      PB.ProfileGenFile = "default_%m.profraw";
+  }
----------------
davide wrote:
> davidxl wrote:
> > can you define a macro for the default profile file name to be shared?
> Sure thing. I generally prefer a global `const std::string` (trying to avoid macros), is that the same to you?
Global `std::string` objects are problematic due to the destructor.

But we just recently added a handy string literal type to LLVM. =]


https://reviews.llvm.org/D29309