[PATCH] D29798: [AMDGPU] Override PSet for M0

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added inline comments.


================
Comment at: lib/Target/AMDGPU/SIRegisterInfo.h:214
 
+  const int *getRegUnitPressureSets(unsigned RegUnit) const override;
+
----------------
arsenm wrote:
> Param name is misleading, it should be Reg not RegUnit
Matt, this is RegUnit. If that would be reg I would not need to call hasRegUnit and just compared register directly. The function is called getRegUnit... and its [[ http://llvm.org/docs/doxygen/html/classllvm_1_1TargetRegisterInfo.html#a890f0083e12db63b68eb74781d16230e | parent definition ]] has RegUnit argument name.

It is a RegUnit, really ;)


Repository:
  rL LLVM

https://reviews.llvm.org/D29798