[PATCH] D29742: [XRay] Implement powerpc64le xray.

[Eric Christopher via Phabricator via llvm-commits]

echristo accepted this revision.
echristo added a comment.

Rough request for more elaborate comments and a couple of inline comments, but nothing major. Feel free to commit after.

Thanks!

-eric



================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1136
+  case TargetOpcode::PATCHABLE_RET:
+    llvm_unreachable("");
+  }
----------------
dberris wrote:
> Probably want a friendly/informative message saying why this ought to be unreachable -- does the codegen not disambiguate tail calls and patchable returns?
+1


================
Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.cpp:68
 PPCInstrInfo::PPCInstrInfo(PPCSubtarget &STI)
-    : PPCGenInstrInfo(PPC::ADJCALLSTACKDOWN, PPC::ADJCALLSTACKUP),
+    : PPCGenInstrInfo(PPC::ADJCALLSTACKDOWN, PPC::ADJCALLSTACKUP, -1,
+                      STI.isPPC64() ? PPC::BLR8 : PPC::BLR),
----------------
-1? Can you make this a bit more descriptive? :)


https://reviews.llvm.org/D29742