[PATCH] D29742: [XRay] Implement powerpc64le xray.

[Dean Michael Berris via Phabricator via llvm-commits]

dberris accepted this revision.
dberris added a comment.
This revision is now accepted and ready to land.

I defer to @echristo on the ppc-specific bits. I suspect you want to stage committing this by doing the LLVM side changes first, and the clang changes next, then finally the compiler-rt implementation.



================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1136
+  case TargetOpcode::PATCHABLE_RET:
+    llvm_unreachable("");
+  }
----------------
Probably want a friendly/informative message saying why this ought to be unreachable -- does the codegen not disambiguate tail calls and patchable returns?


https://reviews.llvm.org/D29742