[PATCH] D29580: [PM] Port ArgumentPromotion to the new pass manager.

Chandler Carruth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 8 01:16:52 PST 2017


chandlerc added a comment.

In https://reviews.llvm.org/D29580#669635, @davide wrote:

> Still I would really like these tests to use `FileCheck` instead of `grep` and check more, but I don't think it makes sense holding a review just for that. I would like to see the output to be checked for some tests (inlined), other than that I'm fine with this patch. Thanks!


Sorry, I tried to do this already and just missed some cases. I've addressed all of them now. One test I just deleted because we actually didn't argument promote anything there, but the rest are now FileCheck based. =]


https://reviews.llvm.org/D29580





More information about the llvm-commits mailing list