[PATCH] D29580: [PM] Port ArgumentPromotion to the new pass manager.

[Davide Italiano via Phabricator via llvm-commits]

davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.

Still I would really like these tests to use `FileCheck` instead of `grep` and check more, but I don't think it makes sense holding a review just for that. I would like to see the output to be checked for some tests (inlined), other than that I'm fine with this patch. Thanks!



================
Comment at: test/Transforms/ArgumentPromotion/callgraph-update.ll:1-2
 ; RUN: opt < %s -argpromotion -simplifycfg -constmerge | llvm-dis
+; RUN: opt < %s -passes='cgscc(argpromotion,function(simplify-cfg)),constmerge' | llvm-dis
+
----------------
Can you check the output is the same here?


================
Comment at: test/Transforms/ArgumentPromotion/crash.ll:1-2
-; RUN: opt -inline -argpromotion < %s
+; RUN: opt -S -inline -argpromotion < %s
+; RUN: opt -S -passes=inline,argpromotion < %s
 ; rdar://7879828
----------------
Can you check the output is the same here?


================
Comment at: test/Transforms/ArgumentPromotion/reserve-tbaa.ll:1-2
 ; RUN: opt < %s -argpromotion -S
+; RUN: opt < %s -passes=argpromotion -S
 
----------------
Can you check the output is the same here? This old test doesn't even check for it.


https://reviews.llvm.org/D29580