[lld] r294006 - Handle numbers followed by ":" in linker scripts.

[Sean Silva via llvm-commits]

On Fri, Feb 3, 2017 at 10:40 PM, Rui Ueyama <ruiu at google.com> wrote:

> On Fri, Feb 3, 2017 at 10:09 PM, Sean Silva via llvm-commits <
> llvm-commits at lists.llvm.org> wrote:
>
>>
>>
>> On Fri, Feb 3, 2017 at 1:19 PM, Mikulin, Dmitry via llvm-commits <
>> llvm-commits at lists.llvm.org> wrote:
>>
>>>
>>> > On Feb 3, 2017, at 10:30 AM, Rafael Avila de Espindola <
>>> rafael.espindola at gmail.com> wrote:
>>> >
>>> > Peter Collingbourne <peter at pcc.me.uk> writes:
>>> >
>>> >> Does this accept "{ global: local; }”?
>>>
>>> Meaning ‘a global named “local”’? Yeah, that’s a problem. We need a test
>>> case for this.
>>> I’ll fix it.
>>>
>>
>> Staring at the gold code, it seems like it treats `local` as a keyword in
>> version scripts so this isn't an issue? You would have to write it as
>> `"local"` or something.
>>
>
> In LLD, we are not distinguishing quoted tokens from unquoted tokens, so
> the quotation marks don't work.
>

It seems that there is a semantic distinction between quoted and unqoted
tokens (besides this issue with treating something as a keyword or quoted
name):
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=blob;f=gold/yyscript.y;h=e533cd3000dc10d6287cd5f569d48799d98627cb;hb=HEAD#l1068

-- Sean Silva


>
>
>>
>> -- Sean Silva
>>
>>
>>>
>>> Dmitry.
>>>
>>>
>>> >>
>>> >
>>> > No, it fails.
>>> >
>>> > Dimitry, can you take a look?
>>> >
>>> > Cheers,
>>> > Rafael
>>> >
>>>
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at lists.llvm.org
>>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>>
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170203/aae01b47/attachment.html>